Unverified Commit 0b0015e6 authored by Sergei Morozov's avatar Sergei Morozov Committed by GitHub

Merge pull request #3359 from morozov/issues/3358

Removed DataAccessTest::testFetchColumnNonExistingIndex() since it covers a bug in PDO
parents 1a2b9aac e7cc1bda
# Upgrade to 2.9 # Upgrade to 2.9
## Deprecated `Statement::fetchColumn()` with an invalid index
Calls to `Statement::fetchColumn()` with an invalid column index currently return `NULL`. In the future, such calls will result in a exception.
## Deprecated `Configuration::getFilterSchemaAssetsExpression()`, `::setFilterSchemaAssetsExpression()` and `AbstractSchemaManager::getFilterSchemaAssetsExpression()`. ## Deprecated `Configuration::getFilterSchemaAssetsExpression()`, `::setFilterSchemaAssetsExpression()` and `AbstractSchemaManager::getFilterSchemaAssetsExpression()`.
Regular expression-based filters are hard to extend by combining together. Instead, you may use callback-based filers via `::getSchemaAssetsFilter()` and `::getSchemaAssetsFilter()`. Callbacks can use regular expressions internally. Regular expression-based filters are hard to extend by combining together. Instead, you may use callback-based filers via `::getSchemaAssetsFilter()` and `::getSchemaAssetsFilter()`. Callbacks can use regular expressions internally.
......
...@@ -888,22 +888,6 @@ class DataAccessTest extends DbalFunctionalTestCase ...@@ -888,22 +888,6 @@ class DataAccessTest extends DbalFunctionalTestCase
); );
} }
/**
* @group DBAL-1028
*/
public function testFetchColumnNonExistingIndex()
{
if ($this->connection->getDriver()->getName() === 'pdo_sqlsrv') {
$this->markTestSkipped(
'Test does not work for pdo_sqlsrv driver as it throws a fatal error for a non-existing column index.'
);
}
self::assertNull(
$this->connection->fetchColumn('SELECT test_int FROM fetch_table WHERE test_int = ?', [1], 1)
);
}
/** /**
* @group DBAL-1028 * @group DBAL-1028
*/ */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment