Commit 2a9dd3cd authored by Marco Pivetta's avatar Marco Pivetta

Merge pull request #782 from Ocramius/hotfix/sqlite-offset-with-no-limit-support

Fix: SQLite offset with no limit support
parents 170817a8 74f2beef
...@@ -657,6 +657,18 @@ class SqlitePlatform extends AbstractPlatform ...@@ -657,6 +657,18 @@ class SqlitePlatform extends AbstractPlatform
return $sql; return $sql;
} }
/**
* {@inheritDoc}
*/
protected function doModifyLimitQuery($query, $limit, $offset)
{
if (null === $limit && null !== $offset) {
return $query . ' LIMIT -1 OFFSET ' . $offset;
}
return parent::doModifyLimitQuery($query, $limit, $offset);
}
/** /**
* {@inheritDoc} * {@inheritDoc}
*/ */
......
...@@ -288,6 +288,12 @@ class SqlitePlatformTest extends AbstractPlatformTestCase ...@@ -288,6 +288,12 @@ class SqlitePlatformTest extends AbstractPlatformTestCase
$this->assertEquals('SELECT * FROM user LIMIT 10', $sql); $this->assertEquals('SELECT * FROM user LIMIT 10', $sql);
} }
public function testModifyLimitQueryWithOffsetAndEmptyLimit()
{
$sql = $this->_platform->modifyLimitQuery('SELECT * FROM user', null, 10);
$this->assertEquals('SELECT * FROM user LIMIT -1 OFFSET 10', $sql);
}
public function getGenerateAlterTableSql() public function getGenerateAlterTableSql()
{ {
return array( return array(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment