Merge pull request #2858 from greg0ire/style_improvements

Style improvements

lib/Doctrine/DBAL/Types/PhpDateTimeMappingType.php

@@ -19,8 +19,6 @@
 
 namespace Doctrine\DBAL\Types;
 
-use Doctrine\DBAL\Platforms\AbstractPlatform;
-
 /**
  * Implementations should map a database type to a PHP DateTimeInterface instance.
  * @internal

lib/Doctrine/DBAL/Types/PhpIntegerMappingType.php

@@ -19,8 +19,6 @@
 
 namespace Doctrine\DBAL\Types;
 
-use Doctrine\DBAL\Platforms\AbstractPlatform;
-
 /**
  * Implementations should map a database type to a PHP integer.
  * @internal

tests/Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php

@@ -563,16 +563,16 @@ abstract class AbstractPlatformTestCase extends \Doctrine\Tests\DbalTestCase
         }
     }
 
-    public function testGetDefaultValueDeclarationSQLForDateType()
+    public function testGetDefaultValueDeclarationSQLForDateType() : void
     {
         $currentDateSql = $this->_platform->getCurrentDateSQL();
-        $field = array(
+        $field = [
             'type'    => Type::getType('date'),
             'default' => $currentDateSql,
-        );
+        ];
 
-        $this->assertEquals(
-            ' DEFAULT '.$currentDateSql,
+        self::assertSame(
+            ' DEFAULT ' . $currentDateSql,
             $this->_platform->getDefaultValueDeclarationSQL($field)
         );
     }

tests/Doctrine/Tests/DBAL/Platforms/SQLServer2008PlatformTest.php

@@ -21,16 +21,16 @@ class SQLServer2008PlatformTest extends AbstractSQLServerPlatformTestCase
         );
     }
 
-    public function testGetDefaultValueDeclarationSQLForDateType()
+    public function testGetDefaultValueDeclarationSQLForDateType() : void
     {
         $currentDateSql = $this->_platform->getCurrentDateSQL();
-        $field = array(
+        $field = [
             'type'    => Type::getType('date'),
             'default' => $currentDateSql,
-        );
+        ];
 
-        $this->assertEquals(
-            " DEFAULT '".$currentDateSql."'",
+        self::assertSame(
+            " DEFAULT '" . $currentDateSql . "'",
             $this->_platform->getDefaultValueDeclarationSQL($field)
         );
     }

tests/Doctrine/Tests/DBAL/Platforms/SQLServer2012PlatformTest.php

@@ -373,16 +373,16 @@ class SQLServer2012PlatformTest extends AbstractSQLServerPlatformTestCase
         self::assertEquals($expectedSql, $sql);
     }
 
-    public function testGetDefaultValueDeclarationSQLForDateType()
+    public function testGetDefaultValueDeclarationSQLForDateType() : void
     {
         $currentDateSql = $this->_platform->getCurrentDateSQL();
-        $field = array(
+        $field = [
             'type'    => Type::getType('date'),
             'default' => $currentDateSql,
-        );
+        ];
 
-        $this->assertEquals(
-            " DEFAULT '".$currentDateSql."'",
+        self::assertSame(
+            " DEFAULT '" . $currentDateSql . "'",
             $this->_platform->getDefaultValueDeclarationSQL($field)
         );
     }

tests/Doctrine/Tests/DBAL/Platforms/SQLServerPlatformTest.php

@@ -59,16 +59,16 @@ class SQLServerPlatformTest extends AbstractSQLServerPlatformTestCase
         );
     }
 
-    public function testGetDefaultValueDeclarationSQLForDateType()
+    public function testGetDefaultValueDeclarationSQLForDateType() : void
     {
         $currentDateSql = $this->_platform->getCurrentDateSQL();
-        $field = array(
+        $field = [
             'type'    => Type::getType('date'),
             'default' => $currentDateSql,
-        );
+        ];
 
-        $this->assertEquals(
-            " DEFAULT '".$currentDateSql."'",
+        self::assertSame(
+            " DEFAULT '" . $currentDateSql . "'",
             $this->_platform->getDefaultValueDeclarationSQL($field)
         );
     }