[Tests] Permutations for Sqlite column comment detection

tests/Doctrine/Tests/DBAL/Schema/SqliteSchemaManagerTest.php

@@ -38,4 +38,65 @@ class SqliteSchemaManagerTest extends \PHPUnit\Framework\TestCase
             ['BINARY', 'b', 'CREATE TABLE "a" (b VARCHAR(42) NOT NULL COLLATE BINARY, bb TEXT COLLATE RTRIM)'],
         ];
     }
+
+    /**
+     * @dataProvider getDataColumnComment
+     *
+     * @group 2865
+     */
+    public function testParseColumnCommentFromSQL($comment, string $column, string $sql) : void
+    {
+        $conn = $this->createMock(Connection::class);
+        $conn->method('getDatabasePlatform')->willReturn(new SqlitePlatform());
+
+        $manager = new SqliteSchemaManager($conn);
+        $ref     = new \ReflectionMethod($manager, 'parseColumnCommentFromSQL');
+        $ref->setAccessible(true);
+
+        self::assertSame($comment, $ref->invoke($manager, $column, $sql));
+    }
+
+    public function getDataColumnComment()
+    {
+        return [
+            'Single column with no comment' => [
+                false, 'a', 'CREATE TABLE "a" ("a" TEXT DEFAULT "a" COLLATE RTRIM)',
+            ],
+            'Single column with type comment' => [
+                '(DC2Type:x)', 'a', 'CREATE TABLE "a" ("a" CLOB DEFAULT NULL COLLATE BINARY --(DC2Type:x)
+)',
+            ],
+            'Multiple similar columns with type comment 1' => [
+                false, 'b', 'CREATE TABLE "a" (a TEXT COLLATE RTRIM, "b" TEXT DEFAULT "a" COLLATE RTRIM, "bb" CLOB DEFAULT NULL COLLATE BINARY --(DC2Type:x)
+)',
+            ],
+            'Multiple similar columns with type comment 2' => [
+                '(DC2Type:x)', 'b', 'CREATE TABLE "a" (a TEXT COLLATE RTRIM, "bb" TEXT DEFAULT "a" COLLATE RTRIM, "b" CLOB DEFAULT NULL COLLATE BINARY --(DC2Type:x)
+)',
+            ],
+            'Multiple similar columns on different lines, with type comment 1' => [
+                false, 'bb', 'CREATE TABLE "a" (a TEXT COLLATE RTRIM, "b" CLOB DEFAULT NULL COLLATE BINARY --(DC2Type:x)
+, "bb" TEXT DEFAULT "a" COLLATE RTRIM',
+            ],
+            'Multiple similar columns on different lines, with type comment 2' => [
+                '(DC2Type:x)', 'bb', 'CREATE TABLE "a" (a TEXT COLLATE RTRIM, "bb" CLOB DEFAULT NULL COLLATE BINARY --(DC2Type:x)
+, "b" TEXT DEFAULT "a" COLLATE RTRIM',
+            ],
+            'Column with numeric but no comment 1' => [
+                false, 'a', 'CREATE TABLE "a" ("a" NUMERIC(10, 0) NOT NULL, "b" CLOB NOT NULL --(DC2Type:array)
+, "c" CHAR(36) NOT NULL --(DC2Type:guid)
+)',
+            ],
+            'Column with numeric but no comment 2' => [
+                false, 'a', 'CREATE TABLE "b" ("a" NUMERIC(10, 0) NOT NULL, "b" CLOB NOT NULL --(DC2Type:array)
+, "c" CHAR(36) NOT NULL --(DC2Type:guid)
+)',
+            ],
+            'Column with numeric but no comment 3' => [
+                '(DC2Type:guid)', 'c', 'CREATE TABLE "b" ("a" NUMERIC(10, 0) NOT NULL, "b" CLOB NOT NULL --(DC2Type:array)
+, "c" CHAR(36) NOT NULL --(DC2Type:guid)
+)',
+            ],
+        ];
+    }
 }