Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
doctrine-dbal
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Tomáš Trávníček
doctrine-dbal
Commits
507de75f
Commit
507de75f
authored
Feb 10, 2015
by
Steve Müller
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
move pre alter table alter index SQL to private method
parent
6177ba44
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
37 additions
and
22 deletions
+37
-22
MySqlPlatform.php
lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
+37
-22
No files found.
lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
View file @
507de75f
...
@@ -657,28 +657,6 @@ class MySqlPlatform extends AbstractPlatform
...
@@ -657,28 +657,6 @@ class MySqlPlatform extends AbstractPlatform
}
}
}
}
// handle columns that are removed from changed indexes
foreach
(
$diff
->
changedIndexes
as
$chgKey
=>
$chgIndex
)
{
// Dropping primary keys requires to unset autoincrement attribute on the particular column first
if
(
$chgIndex
->
isPrimary
()
&&
$diff
->
fromTable
instanceof
Table
)
{
// when chgIndex->isPrimary we can be sure fromTable->hasPrimaryKey is true
foreach
(
$diff
->
fromTable
->
getPrimaryKeyColumns
()
as
$columnName
)
{
$column
=
$diff
->
fromTable
->
getColumn
(
$columnName
);
if
(
$column
->
getAutoincrement
()
===
true
&&
in_array
(
$columnName
,
$chgIndex
->
getColumns
())
===
false
)
{
$column
->
setAutoincrement
(
false
);
$sql
[]
=
'ALTER TABLE '
.
$table
.
' MODIFY '
.
$this
->
getColumnDeclarationSQL
(
$column
->
getQuotedName
(
$this
),
$column
->
toArray
());
// original autoincrement information might be needed later on by other parts of the table alteration
$column
->
setAutoincrement
(
true
);
}
}
}
}
$engine
=
'INNODB'
;
$engine
=
'INNODB'
;
if
(
$diff
->
fromTable
instanceof
Table
&&
$diff
->
fromTable
->
hasOption
(
'engine'
))
{
if
(
$diff
->
fromTable
instanceof
Table
&&
$diff
->
fromTable
->
hasOption
(
'engine'
))
{
...
@@ -694,6 +672,7 @@ class MySqlPlatform extends AbstractPlatform
...
@@ -694,6 +672,7 @@ class MySqlPlatform extends AbstractPlatform
$sql
=
array_merge
(
$sql
=
array_merge
(
$sql
,
$sql
,
$this
->
getPreAlterTableAlterIndexForeignKeySQL
(
$diff
),
parent
::
getPreAlterTableIndexForeignKeySQL
(
$diff
),
parent
::
getPreAlterTableIndexForeignKeySQL
(
$diff
),
$this
->
getPreAlterTableRenameIndexForeignKeySQL
(
$diff
)
$this
->
getPreAlterTableRenameIndexForeignKeySQL
(
$diff
)
);
);
...
@@ -701,6 +680,42 @@ class MySqlPlatform extends AbstractPlatform
...
@@ -701,6 +680,42 @@ class MySqlPlatform extends AbstractPlatform
return
$sql
;
return
$sql
;
}
}
/**
* @param TableDiff $diff The table diff to gather the SQL for.
*
* @return array
*/
private
function
getPreAlterTableAlterIndexForeignKeySQL
(
TableDiff
$diff
)
{
$sql
=
array
();
$table
=
$diff
->
getName
(
$this
)
->
getQuotedName
(
$this
);
foreach
(
$diff
->
changedIndexes
as
$changedIndex
)
{
// Changed primary key
if
(
$changedIndex
->
isPrimary
()
&&
$diff
->
fromTable
instanceof
Table
)
{
foreach
(
$diff
->
fromTable
->
getPrimaryKeyColumns
()
as
$columnName
)
{
$column
=
$diff
->
fromTable
->
getColumn
(
$columnName
);
// Check if an autoincrement column was dropped from the primary key.
if
(
$column
->
getAutoincrement
()
&&
!
in_array
(
$columnName
,
$changedIndex
->
getColumns
()))
{
// The autoincrement attribute needs to be removed from the dropped column
// before we can drop and recreate the primary key.
$column
->
setAutoincrement
(
false
);
$sql
[]
=
'ALTER TABLE '
.
$table
.
' MODIFY '
.
$this
->
getColumnDeclarationSQL
(
$column
->
getQuotedName
(
$this
),
$column
->
toArray
());
// Restore the autoincrement attribute as it might be needed later on
// by other parts of the table alteration.
$column
->
setAutoincrement
(
true
);
}
}
}
}
return
$sql
;
}
/**
/**
* @param TableDiff $diff The table diff to gather the SQL for.
* @param TableDiff $diff The table diff to gather the SQL for.
*
*
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment