Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
doctrine-dbal
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Tomáš Trávníček
doctrine-dbal
Commits
79e369e8
Unverified
Commit
79e369e8
authored
Dec 04, 2018
by
roger.codina
Committed by
Sergei Morozov
Dec 06, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
ResultCacheStatement lost its cache capability on fetchAll method
parent
125fb5e7
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
1 deletion
+14
-1
ResultCacheStatement.php
lib/Doctrine/DBAL/Cache/ResultCacheStatement.php
+4
-1
ResultCacheTest.php
tests/Doctrine/Tests/DBAL/Functional/ResultCacheTest.php
+10
-0
No files found.
lib/Doctrine/DBAL/Cache/ResultCacheStatement.php
View file @
79e369e8
...
...
@@ -166,7 +166,10 @@ class ResultCacheStatement implements IteratorAggregate, ResultStatement
*/
public
function
fetchAll
(
$fetchMode
=
null
,
$fetchArgument
=
null
,
$ctorArgs
=
null
)
{
return
$this
->
statement
->
fetchAll
(
$fetchMode
,
$fetchArgument
,
$ctorArgs
);
$this
->
data
=
$this
->
statement
->
fetchAll
(
$fetchMode
,
$fetchArgument
,
$ctorArgs
);
$this
->
emptied
=
true
;
return
$this
->
data
;
}
/**
...
...
tests/Doctrine/Tests/DBAL/Functional/ResultCacheTest.php
View file @
79e369e8
...
...
@@ -166,6 +166,16 @@ class ResultCacheTest extends DbalFunctionalTestCase
self
::
assertCount
(
2
,
$this
->
sqlLogger
->
queries
);
}
public
function
testFetchAllAndFinishSavesCache
()
{
$layerCache
=
new
ArrayCache
();
$stmt
=
$this
->
connection
->
executeQuery
(
'SELECT * FROM caching WHERE test_int > 500'
,
[],
[],
new
QueryCacheProfile
(
10
,
'testcachekey'
,
$layerCache
));
$stmt
->
fetchAll
();
$stmt
->
closeCursor
();
self
::
assertCount
(
1
,
$layerCache
->
fetch
(
'testcachekey'
));
}
public
function
assertCacheNonCacheSelectSameFetchModeAreEqual
(
$expectedResult
,
$fetchMode
)
{
$stmt
=
$this
->
connection
->
executeQuery
(
'SELECT * FROM caching ORDER BY test_int ASC'
,
[],
[],
new
QueryCacheProfile
(
10
,
'testcachekey'
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment