Merge pull request #4107 from morozov/phpstan-irrelevant-suppressions

Remove the suppressed errors that PHPStan no longer reports

phpstan.neon.dist

@@ -9,34 +9,18 @@ parameters:
     checkMissingIterableValueType: false
     checkGenericClassInNonGenericObjectType: false
     ignoreErrors:
-        # extension not available
-        - '~^(Used )?(Function|Constant) sasql_\S+ not found\.\z~i'
-
         # removing it would be BC break
         - '~^Constructor of class Doctrine\\DBAL\\Schema\\Table has an unused parameter \$idGeneratorType\.\z~'
 
         # changing these would be a BC break, to be done in next major
         - "~^Casting to bool something that's already bool.~"
-        - '~^Property Doctrine\\DBAL\\Schema\\Table::\$_primaryKeyName \(string\) does not accept (default value of type )?false\.\z~'
         - '~^Property Doctrine\\DBAL\\Schema\\Schema::\$_schemaConfig \(Doctrine\\DBAL\\Schema\\SchemaConfig\) does not accept default value of type false\.\z~'
-        - '~^Method Doctrine\\DBAL\\Schema\\ForeignKeyConstraint::onEvent\(\) should return string\|null but returns false\.\z~'
-        - '~^Method Doctrine\\DBAL\\Schema\\(Oracle|PostgreSql|SQLServer)SchemaManager::_getPortableTableDefinition\(\) should return array but returns string\.\z~'
-        - '~^Method Doctrine\\DBAL\\Driver\\OCI8\\OCI8Connection::lastInsertId\(\) should return string but returns (int|false)\.\z~'
         - '~^Return type \(int\|false\) of method Doctrine\\DBAL\\Driver\\OCI8\\OCI8Connection\:\:lastInsertId\(\) should be compatible with return type \(string\) of method Doctrine\\DBAL\\Driver\\Connection::lastInsertId\(\)~'
 
-        # https://github.com/phpstan/phpstan/issues/3527
-        -
-            message: '~^Call to private method sqliteCreateFunction\(\) of parent class PDO\.$~'
-            path: %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php
-
         # https://github.com/phpstan/phpstan/issues/2857
         # TODO: remove in 4.0.0
         - '~^Parameter #2 \$registeredAliases of static method Doctrine\\DBAL\\Query\\QueryException::nonUniqueAlias\(\) expects array<string>, array<int, int\|string> given\.\z~'
 
-        # legacy variadic-like signature
-        # TODO: remove in 3.0.0
-        - '~^Method Doctrine\\DBAL(\\.*)?Connection::query\(\) invoked with \d+ parameters?, 0 required\.\z~'
-
         # some drivers actually do accept 2nd parameter...
         - '~^Method Doctrine\\DBAL\\Platforms\\AbstractPlatform::getListTableForeignKeysSQL\(\) invoked with \d+ parameters, 1 required\.\z~'
 
@@ -52,9 +36,6 @@ parameters:
             message: '~^Strict comparison using === between true and null will always evaluate to false\.$~'
             path: %currentWorkingDirectory%/src/Driver/Mysqli/Result.php
 
-        # The ReflectionException in the case when the class does not exist is acceptable and does not need to be handled
-        - '~^Parameter #1 \$argument of class ReflectionClass constructor expects class-string<T of object>\|T of object, string given\.$~'
-
         # https://github.com/phpstan/phpstan/issues/3132
         -
             message: '~^Call to function in_array\(\) with arguments Doctrine\\DBAL\\Schema\\Column, array<string> and true will always evaluate to false\.$~'
@@ -81,55 +62,6 @@ parameters:
         # Needs Generics
         - '~Method Doctrine\\DBAL\\Schema\\SchemaDiff::getNewTablesSortedByDependencies\(\) should return array<Doctrine\\DBAL\\Schema\\Table> but returns array<object>.~'
 
-        # This is deprecated code. Fixing the issue may cause a BC break.
-        # TODO: remove in 3.0.0
-        -
-            message: '~^Return type \(Doctrine\\DBAL\\Platforms\\DrizzlePlatform\) of method Doctrine\\DBAL\\Driver\\DrizzlePDOMySql\\Driver::getDatabasePlatform\(\) should be compatible with return type \(Doctrine\\DBAL\\Platforms\\MySqlPlatform\) of method Doctrine\\DBAL\\Driver\\AbstractMySQLDriver::getDatabasePlatform\(\)$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/DrizzlePDOMySql/Driver.php
-
-        # This is deprecated code. Fixing the issue may cause a BC break.
-        # TODO: remove in 3.0.0
-        -
-            message: '~^Return type \(Doctrine\\DBAL\\Schema\\DrizzleSchemaManager\) of method Doctrine\\DBAL\\Driver\\DrizzlePDOMySql\\Driver::getSchemaManager\(\) should be compatible with return type \(Doctrine\\DBAL\\Schema\\MySqlSchemaManager\) of method Doctrine\\DBAL\\Driver\\AbstractMySQLDriver::getSchemaManager\(\)$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/DrizzlePDOMySql/Driver.php
-
-        # This is deprecated code. Fixing the issue may cause a BC break.
-        # TODO: remove in 3.0.0
-        -
-            message: '~^Return type \(int\) of method Doctrine\\DBAL\\Driver\\Mysqli\\MysqliConnection::errorCode\(\) should be compatible with return type \(string\|null\) of method Doctrine\\DBAL\\Driver\\Connection::errorCode\(\)$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/Mysqli/MysqliConnection.php
-
-        # This is deprecated code. Fixing the issue may cause a BC break.
-        # TODO: remove in 3.0.0
-        -
-            message: '~^Return type \(string\) of method Doctrine\\DBAL\\Driver\\Mysqli\\MysqliConnection::errorInfo\(\) should be compatible with return type \(array\) of method Doctrine\\DBAL\\Driver\\Connection::errorInfo\(\)$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/Mysqli/MysqliConnection.php
-
-        # Fixing the issue may cause a BC break.
-        # TODO: fix in 3.0.0
-        -
-            message: '~^Parameter \#2 \$sqlState of class Doctrine\\DBAL\\Driver\\Mysqli\\MysqliException constructor expects string\|null, int given\.$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/Mysqli/MysqliStatement.php
-
-        # This is deprecated code. Fixing the issue may cause a BC break.
-        # TODO: remove in 3.0.0
-        -
-            message: '~^Return type \(string\) of method Doctrine\\DBAL\\Driver\\Mysqli\\MysqliStatement::errorInfo\(\) should be compatible with return type \(array\) of method Doctrine\\DBAL\\Driver\\Statement::errorInfo\(\)$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/Mysqli/MysqliStatement.php
-
-        # This is poorly typed deprecated code. The issue doesn't have practical implication and can be suppressed.
-        # TODO: remove in 3.0.0
-        -
-            message: '~^Parameter \#1 \$how of method PDOStatement\:\:fetchAll\(\) expects int, array\|int\|null given\.$~'
-            paths:
-                - %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOStatement.php
-
         # https://github.com/phpstan/phpstan/issues/3134
         -
             message: '~^Call to static method PHPUnit\\Framework\\Assert::assertSame\(\) with Doctrine\\DBAL\\Types\\Type and Doctrine\\DBAL\\Types\\Type will always evaluate to true\.$~'
@@ -139,7 +71,6 @@ parameters:
         -
             message: '~^Construct empty\(\) is not allowed. Use more strict comparison\.~'
             paths:
-                - %currentWorkingDirectory%/src/Driver/*/*Connection.php
                 - %currentWorkingDirectory%/src/Driver/*/Driver.php
                 - %currentWorkingDirectory%/src/Driver/AbstractOracleDriver/EasyConnectString.php
                 - %currentWorkingDirectory%/src/Platforms/*Platform.php
@@ -158,7 +89,6 @@ parameters:
         -
             message: '~^Variable method call on .*~'
             paths:
-                - %currentWorkingDirectory%/src/Schema/AbstractSchemaManager.php
                 - %currentWorkingDirectory%/src/Schema/Column.php
 
         # https://github.com/phpstan/phpstan/issues/3146
@@ -174,11 +104,6 @@ parameters:
                 - %currentWorkingDirectory%/src/Id/TableGenerator.php
                 - %currentWorkingDirectory%/src/Schema/SqliteSchemaManager.php
 
-        -
-            message: '~Method Doctrine\\DBAL\\Driver\\PDOSqlsrv\\Connection\:\:lastInsertId\(\) should return string but returns string\|false\|null\.~'
-            paths:
-                - %currentWorkingDirectory%/src/Driver/PDOSqlsrv/Connection.php
-
         -
             message: '~Return type \(Doctrine\\DBAL\\Portability\\Statement\) of method Doctrine\\DBAL\\Portability\\Connection::prepare\(\) should be compatible with return type \(Doctrine\\DBAL\\Statement\) of method Doctrine\\DBAL\\Connection::prepare\(\)~'
             paths: