Convert if/else to ternary

b1ae165a · Bill Schaller · Steve Müller · fcfc1898 · b1ae165a
Commit b1ae165a authored Dec 15, 2015 by Bill Schaller Committed by Steve Müller Dec 15, 2015
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

SQLServerPlatform.php lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php +3 -6

No files found.
--- a/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
+++ b/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
@@ -1274,12 +1274,9 @@ class SQLServerPlatform extends AbstractPlatform
            if ($query[$currentPosition] === ')') {
                $parenCount++;
            }
-            if ($parenCount === 0) {
+
            // Only yank query text on the same nesting level as the ORDER BY clause.
-                $subQueryBuffer = $query[$currentPosition] . $subQueryBuffer;
-            } else {
-                $subQueryBuffer = " " . $subQueryBuffer;
-            }
+            $subQueryBuffer = ($parenCount === 0 ? $query[$currentPosition] : " ") . $subQueryBuffer;

            $currentPosition--;
        }