[DBAL-510] Fix tests (remove SQL ones, add functional test.

doctrine-common @ d1c7d433

-Subproject commit 15b04ec520ccded3dc0eba65b12a69ff1931360f
+Subproject commit d1c7d4334e38cad603a5c863d4c7b91bb04ec6b2

tests/Doctrine/Tests/DBAL/Functional/Ticket/DBAL510Test.php

+<?php
+
+namespace Doctrine\Tests\DBAL\Functional\Ticket;
+
+use Doctrine\DBAL\Schema\Comparator;
+use Doctrine\DBAL\Schema\Table;
+
+/**
+ * @group DBAL-510
+ */
+class DBAL510Test extends \Doctrine\Tests\DbalFunctionalTestCase
+{
+    public function setUp()
+    {
+        parent::setUp();
+
+        if ($this->_conn->getDatabasePlatform()->getName() !== "postgresql") {
+            $this->markTestSkipped('PostgreSQL Only test');
+        }
+    }
+
+    public function testSearchPathSchemaChanges()
+    {
+        $table = new Table("dbal510tbl");
+        $table->addColumn('id', 'integer');
+        $table->setPrimaryKey(array('id'));
+
+        $this->_conn->getSchemaManager()->createTable($table);
+
+        $onlineTable = $this->_conn->getSchemaManager()->listTableDetails('dbal510tbl');
+
+        $comparator = new Comparator();
+        $diff = $comparator->diffTable($onlineTable, $table);
+
+        $this->assertFalse($diff);
+    }
+}

tests/Doctrine/Tests/DBAL/Platforms/PostgreSqlPlatformTest.php

@@ -304,66 +304,5 @@ class PostgreSqlPlatformTest extends AbstractPlatformTestCase
         $this->assertEquals('1', $platform->convertBooleans(true));
         $this->assertEquals('0', $platform->convertBooleans(false));
     }
-    
-    public function testGetListTableColumnsSQL() {
-      $this->assertEquals($this->_platform->getListTableColumnsSQL('test_table'),
-      "SELECT
-                    a.attnum,
-                    a.attname AS field,
-                    t.typname AS type,
-                    format_type(a.atttypid, a.atttypmod) AS complete_type,
-                    (SELECT t1.typname FROM pg_catalog.pg_type t1 WHERE t1.oid = t.typbasetype) AS domain_type,
-                    (SELECT format_type(t2.typbasetype, t2.typtypmod) FROM pg_catalog.pg_type t2
-                     WHERE t2.typtype = 'd' AND t2.typname = format_type(a.atttypid, a.atttypmod)) AS domain_complete_type,
-                    a.attnotnull AS isnotnull,
-                    (SELECT 't'
-                     FROM pg_index
-                     WHERE c.oid = pg_index.indrelid
-                        AND pg_index.indkey[0] = a.attnum
-                        AND pg_index.indisprimary = 't'
-                    ) AS pri,
-                    (SELECT pg_attrdef.adsrc
-                     FROM pg_attrdef
-                     WHERE c.oid = pg_attrdef.adrelid
-                        AND pg_attrdef.adnum=a.attnum
-                    ) AS default,
-                    (SELECT pg_description.description
-                        FROM pg_description WHERE pg_description.objoid = c.oid AND a.attnum = pg_description.objsubid
-                    ) AS comment
-                    FROM pg_attribute a, pg_class c, pg_type t, pg_namespace n
-                    WHERE n.nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND c.relname = 'test_table' AND n.nspname = ANY(string_to_array((select replace(setting,'\"\$user\"',user) from pg_catalog.pg_settings where name = 'search_path'),','))
-                        AND a.attnum > 0
-                        AND a.attrelid = c.oid
-                        AND a.atttypid = t.oid
-                        AND n.oid = c.relnamespace
-                    ORDER BY a.attnum"
-      );
-    }
-    
-    public function testGetListTableForeignKeysSQL() {
-      $this->assertEquals($this->_platform->getListTableForeignKeysSQL('test_table'),
-        "SELECT r.conname, pg_catalog.pg_get_constraintdef(r.oid, true) as condef
-                  FROM pg_catalog.pg_constraint r
-                  WHERE r.conrelid =
-                  (
-                      SELECT c.oid
-                      FROM pg_catalog.pg_class c, pg_catalog.pg_namespace n
-                      WHERE n.nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND c.relname = 'test_table' AND n.nspname = ANY(string_to_array((select replace(setting,'\"\$user\"',user) from pg_catalog.pg_settings where name = 'search_path'),',')) AND n.oid = c.relnamespace
-                  )
-                  AND r.contype = 'f'"
-      );
-    }
-    
-    public function testGetListTableIndexesSQL() {
-      $this->assertEquals($this->_platform->getListTableIndexesSQL('test_table'), "SELECT relname, pg_index.indisunique, pg_index.indisprimary,
-                       pg_index.indkey, pg_index.indrelid
-                 FROM pg_class, pg_index
-                 WHERE oid IN (
-                    SELECT indexrelid
-                    FROM pg_index si, pg_class sc, pg_namespace sn
-                    WHERE sn.nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND sc.relname = 'test_table' AND sn.nspname = ANY(string_to_array((select replace(setting,'\"\$user\"',user) from pg_catalog.pg_settings where name = 'search_path'),',')) AND sc.oid=si.indrelid AND sc.relnamespace = sn.oid
-                 ) AND pg_index.indexrelid = oid"
-      );
-    }
 }