Skip to content

D
doctrine-dbal
Unverified Commit f570179f authored by Sergei Morozov's avatar Sergei Morozov
Browse files
Options

Remove useless assertion message that make lines exceed the length limit

parent 85bc13de
Show whitespace changes
Inline Side-by-side
Showing with 26 additions and 36 deletions
tests/Doctrine/Tests/DBAL/Platforms/AbstractMySQLPlatformTestCase.php
View file @ f570179f
......@@ -56,9 +56,9 @@ abstract class AbstractMySQLPlatformTestCase extends AbstractPlatformTestCase
public function testGeneratesSqlSnippets(): void
{
self::assertEquals('RLIKE', $this->platform->getRegexpExpression(), 'Regular expression operator is not correct');
self::assertEquals('`', $this->platform->getIdentifierQuoteCharacter(), 'Quote character is not correct');
self::assertEquals('CONCAT(column1, column2, column3)', $this->platform->getConcatExpression('column1', 'column2', 'column3'), 'Concatenation function is not correct');
self::assertEquals('RLIKE', $this->platform->getRegexpExpression());
self::assertEquals('`', $this->platform->getIdentifierQuoteCharacter());
self::assertEquals('CONCAT(column1, column2, column3)', $this->platform->getConcatExpression('column1', 'column2', 'column3'));
}
public function testGeneratesTransactionsCommands(): void
......@@ -118,13 +118,11 @@ abstract class AbstractMySQLPlatformTestCase extends AbstractPlatformTestCase
);
self::assertEquals(
'VARCHAR(50)',
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50]),
'Variable string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50])
);
self::assertEquals(
'VARCHAR(255)',
$this->platform->getVarcharTypeDeclarationSQL([]),
'Long string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL([])
);
}
......
tests/Doctrine/Tests/DBAL/Platforms/AbstractPostgreSqlPlatformTestCase.php
View file @ f570179f
......@@ -148,11 +148,11 @@ abstract class AbstractPostgreSqlPlatformTestCase extends AbstractPlatformTestCa
public function testGeneratesSqlSnippets(): void
{
self::assertEquals('SIMILAR TO', $this->platform->getRegexpExpression(), 'Regular expression operator is not correct');
self::assertEquals('"', $this->platform->getIdentifierQuoteCharacter(), 'Identifier quote character is not correct');
self::assertEquals('column1 || column2 || column3', $this->platform->getConcatExpression('column1', 'column2', 'column3'), 'Concatenation expression is not correct');
self::assertEquals('SUBSTRING(column FROM 5)', $this->platform->getSubstringExpression('column', 5), 'Substring expression without length is not correct');
self::assertEquals('SUBSTRING(column FROM 1 FOR 5)', $this->platform->getSubstringExpression('column', 1, 5), 'Substring expression with length is not correct');
self::assertEquals('SIMILAR TO', $this->platform->getRegexpExpression());
self::assertEquals('"', $this->platform->getIdentifierQuoteCharacter());
self::assertEquals('column1 || column2 || column3', $this->platform->getConcatExpression('column1', 'column2', 'column3'));
self::assertEquals('SUBSTRING(column FROM 5)', $this->platform->getSubstringExpression('column', 5));
self::assertEquals('SUBSTRING(column FROM 1 FOR 5)', $this->platform->getSubstringExpression('column', 1, 5));
}
public function testGeneratesTransactionCommands(): void
......@@ -276,13 +276,11 @@ abstract class AbstractPostgreSqlPlatformTestCase extends AbstractPlatformTestCa
);
self::assertEquals(
'VARCHAR(50)',
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50]),
'Variable string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50])
);
self::assertEquals(
'VARCHAR(255)',
$this->platform->getVarcharTypeDeclarationSQL([]),
'Long string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL([])
);
}
......
tests/Doctrine/Tests/DBAL/Platforms/AbstractSQLServerPlatformTestCase.php
View file @ f570179f
......@@ -70,8 +70,8 @@ abstract class AbstractSQLServerPlatformTestCase extends AbstractPlatformTestCas
self::assertEquals('CONVERT(date, GETDATE())', $this->platform->getCurrentDateSQL());
self::assertEquals('CONVERT(time, GETDATE())', $this->platform->getCurrentTimeSQL());
self::assertEquals('CURRENT_TIMESTAMP', $this->platform->getCurrentTimestampSQL());
self::assertEquals('"', $this->platform->getIdentifierQuoteCharacter(), 'Identifier quote character is not correct');
self::assertEquals('(column1 + column2 + column3)', $this->platform->getConcatExpression('column1', 'column2', 'column3'), 'Concatenation expression is not correct');
self::assertEquals('"', $this->platform->getIdentifierQuoteCharacter());
self::assertEquals('(column1 + column2 + column3)', $this->platform->getConcatExpression('column1', 'column2', 'column3'));
}
public function testGeneratesTransactionsCommands(): void
......@@ -132,13 +132,11 @@ abstract class AbstractSQLServerPlatformTestCase extends AbstractPlatformTestCas
);
self::assertEquals(
'NVARCHAR(50)',
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50]),
'Variable string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50])
);
self::assertEquals(
'NVARCHAR(255)',
$this->platform->getVarcharTypeDeclarationSQL([]),
'Long string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL([])
);
self::assertSame('VARCHAR(MAX)', $this->platform->getClobTypeDeclarationSQL([]));
self::assertSame(
......
tests/Doctrine/Tests/DBAL/Platforms/OraclePlatformTest.php
View file @ f570179f
......@@ -121,13 +121,13 @@ class OraclePlatformTest extends AbstractPlatformTestCase
{
$this->expectException(DBALException::class);
self::assertEquals('RLIKE', $this->platform->getRegexpExpression(), 'Regular expression operator is not correct');
self::assertEquals('RLIKE', $this->platform->getRegexpExpression());
}
public function testGeneratesSqlSnippets(): void
{
self::assertEquals('"', $this->platform->getIdentifierQuoteCharacter(), 'Identifier quote character is not correct');
self::assertEquals('column1 || column2 || column3', $this->platform->getConcatExpression('column1', 'column2', 'column3'), 'Concatenation expression is not correct');
self::assertEquals('"', $this->platform->getIdentifierQuoteCharacter());
self::assertEquals('column1 || column2 || column3', $this->platform->getConcatExpression('column1', 'column2', 'column3'));
}
public function testGeneratesTransactionsCommands(): void
......@@ -195,13 +195,11 @@ class OraclePlatformTest extends AbstractPlatformTestCase
);
self::assertEquals(
'VARCHAR2(50)',
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50]),
'Variable string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50])
);
self::assertEquals(
'VARCHAR2(255)',
$this->platform->getVarcharTypeDeclarationSQL([]),
'Long string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL([])
);
}
......
tests/Doctrine/Tests/DBAL/Platforms/SqlitePlatformTest.php
View file @ f570179f
......@@ -42,9 +42,9 @@ class SqlitePlatformTest extends AbstractPlatformTestCase
public function testGeneratesSqlSnippets(): void
{
self::assertEquals('REGEXP', $this->platform->getRegexpExpression(), 'Regular expression operator is not correct');
self::assertEquals('SUBSTR(column, 5, LENGTH(column))', $this->platform->getSubstringExpression('column', 5), 'Substring expression without length is not correct');
self::assertEquals('SUBSTR(column, 0, 5)', $this->platform->getSubstringExpression('column', 0, 5), 'Substring expression with length is not correct');
self::assertEquals('REGEXP', $this->platform->getRegexpExpression());
self::assertEquals('SUBSTR(column, 5, LENGTH(column))', $this->platform->getSubstringExpression('column', 5));
self::assertEquals('SUBSTR(column, 0, 5)', $this->platform->getSubstringExpression('column', 0, 5));
}
public function testGeneratesTransactionCommands(): void
......@@ -236,13 +236,11 @@ class SqlitePlatformTest extends AbstractPlatformTestCase
);
self::assertEquals(
'VARCHAR(50)',
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50]),
'Variable string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL(['length' => 50])
);
self::assertEquals(
'VARCHAR(255)',
$this->platform->getVarcharTypeDeclarationSQL([]),
'Long string declaration is not correct'
$this->platform->getVarcharTypeDeclarationSQL([])
);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment