Merge pull request #268 from deeky666/remove-deprecated-getshowdatabasessql-function

Remove deprecated getShowDatabasesSQL() from Platforms

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

@@ -1972,16 +1972,6 @@ abstract class AbstractPlatform
         return $tableName;
     }
 
-    /**
-     * Get sql query to show a list of database.
-     *
-     * @return string
-     */
-    public function getShowDatabasesSQL()
-    {
-        throw DBALException::notSupported(__METHOD__);
-    }
-
     /**
      * Obtain DBMS specific SQL code portion needed to set the FOREIGN KEY constraint
      * of a field declaration to be used in statements like CREATE TABLE.

lib/Doctrine/DBAL/Platforms/MySqlPlatform.php

@@ -294,14 +294,6 @@ class MySqlPlatform extends AbstractPlatform
         return true;
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    public function getShowDatabasesSQL()
-    {
-        return 'SHOW DATABASES';
-    }
-
     public function getListTablesSQL()
     {
         return "SHOW FULL TABLES WHERE Table_type = 'BASE TABLE'";

lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php

@@ -393,14 +393,6 @@ class SQLServerPlatform extends AbstractPlatform
         return 'INSERT INTO ' . $quotedTableName . ' DEFAULT VALUES';
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    public function getShowDatabasesSQL()
-    {
-        return 'SHOW DATABASES';
-    }
-
     /**
      * {@inheritDoc}
      */

tests/Doctrine/Tests/DBAL/Platforms/MySqlPlatformTest.php

@@ -75,7 +75,7 @@ class MySqlPlatformTest extends AbstractPlatformTestCase
 
     public function testGeneratesDDLSnippets()
     {
-        $this->assertEquals('SHOW DATABASES', $this->_platform->getShowDatabasesSQL());
+        $this->assertEquals('SHOW DATABASES', $this->_platform->getListDatabasesSQL());
         $this->assertEquals('CREATE DATABASE foobar', $this->_platform->getCreateDatabaseSQL('foobar'));
         $this->assertEquals('DROP DATABASE foobar', $this->_platform->getDropDatabaseSQL('foobar'));
         $this->assertEquals('DROP TABLE foobar', $this->_platform->getDropTableSQL('foobar'));

tests/Doctrine/Tests/DBAL/Platforms/OraclePlatformTest.php

@@ -116,14 +116,6 @@ class OraclePlatformTest extends AbstractPlatformTestCase
         );
     }
 
-    /**
-     * @expectedException Doctrine\DBAL\DBALException
-     */
-    public function testShowDatabasesThrowsException()
-    {
-        $this->assertEquals('SHOW DATABASES', $this->_platform->getShowDatabasesSQL());
-    }
-
     /**
      * @expectedException Doctrine\DBAL\DBALException
      */

tests/Doctrine/Tests/DBAL/Platforms/SQLServerPlatformTest.php

@@ -67,7 +67,7 @@ class SQLServerPlatformTest extends AbstractPlatformTestCase
     {
         $dropDatabaseExpectation = 'DROP DATABASE foobar';
 
-        $this->assertEquals('SHOW DATABASES', $this->_platform->getShowDatabasesSQL());
+        $this->assertEquals('SELECT * FROM SYS.DATABASES', $this->_platform->getListDatabasesSQL());
         $this->assertEquals('CREATE DATABASE foobar', $this->_platform->getCreateDatabaseSQL('foobar'));
         $this->assertEquals($dropDatabaseExpectation, $this->_platform->getDropDatabaseSQL('foobar'));
         $this->assertEquals('DROP TABLE foobar', $this->_platform->getDropTableSQL('foobar'));