Skip to content

D
doctrine-dbal
Commit fcfc1898 authored by Bill Schaller's avatar Bill Schaller Committed by Steve Müller
Browse files
Options

Strict comparison for parens

parent bbf513ba
Show whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php
View file @ fcfc1898
...@@ -1228,9 +1228,9 @@ class SQLServerPlatform extends AbstractPlatform ...@@ -1228,9 +1228,9 @@ class SQLServerPlatform extends AbstractPlatform
$currentPosition = $orderByPos; $currentPosition = $orderByPos;
while ($parenCount >= 0 && $currentPosition < $qLen) { while ($parenCount >= 0 && $currentPosition < $qLen) {
if ($query[$currentPosition] == '(') { if ($query[$currentPosition] === '(') {
$parenCount++; $parenCount++;
} elseif ($query[$currentPosition] == ')') { } elseif ($query[$currentPosition] === ')') {
$parenCount--; $parenCount--;
} }
...@@ -1268,10 +1268,10 @@ class SQLServerPlatform extends AbstractPlatform ...@@ -1268,10 +1268,10 @@ class SQLServerPlatform extends AbstractPlatform
// If $parenCount goes negative, we've exited the subquery we're examining. // If $parenCount goes negative, we've exited the subquery we're examining.
// If $currentPosition goes negative, we've reached the beginning of the query. // If $currentPosition goes negative, we've reached the beginning of the query.
while ($parenCount >= 0 && $currentPosition >= 0) { while ($parenCount >= 0 && $currentPosition >= 0) {
if ($query[$currentPosition] == '(') { if ($query[$currentPosition] === '(') {
$parenCount--; $parenCount--;
} }
if ($query[$currentPosition] == ')') { if ($query[$currentPosition] === ')') {
$parenCount++; $parenCount++;
} }
if ($parenCount === 0) { if ($parenCount === 0) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment