Unverified Commit 1bf8e3a6 authored by Andy Truong's avatar Andy Truong Committed by Michael Moravec

Don't skip column options.

parent 62be8580
......@@ -132,7 +132,7 @@ class Column extends AbstractAsset
$name
), E_USER_DEPRECATED);
return $this;
continue;
}
$this->$method($value);
}
......
......@@ -65,6 +65,19 @@ class ColumnTest extends \PHPUnit\Framework\TestCase
new Column('foo', $this->createMock(Type::class), ['unknown_option' => 'bar']);
}
/**
* @group legacy
* @expectedDeprecation The "unknown_option" column option is not supported, setting it is deprecated and will cause an error in Doctrine 3.0
*/
public function testOptionsShouldNotBeIgnored() : void
{
$col1 = new Column('bar', Type::getType(Type::INTEGER), ['unknown_option' => 'bar', 'notnull' => true]);
self::assertTrue($col1->getNotnull());
$col2 = new Column('bar', Type::getType(Type::INTEGER), ['unknown_option' => 'bar', 'notnull' => false]);
self::assertFalse($col2->getNotnull());
}
/**
* @return Column
*/
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment