Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
doctrine-dbal
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Tomáš Trávníček
doctrine-dbal
Commits
2dc589c5
Commit
2dc589c5
authored
Feb 01, 2013
by
everus
Committed by
Benjamin Eberlei
Apr 14, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix OFFSET without LIMIT cause MySQL syntax error.
parent
4b659d32
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
0 deletions
+24
-0
MySqlPlatform.php
lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
+18
-0
MySqlPlatformTest.php
tests/Doctrine/Tests/DBAL/Platforms/MySqlPlatformTest.php
+6
-0
No files found.
lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
View file @
2dc589c5
...
...
@@ -44,6 +44,24 @@ class MySqlPlatform extends AbstractPlatform
const
LENGTH_LIMIT_BLOB
=
65535
;
const
LENGTH_LIMIT_MEDIUMBLOB
=
16777215
;
/**
* Adds MySQL-specific LIMIT clause to the query
* 18446744073709551615 is 2^64-1 maximum of unsigned BIGINT the biggest limit possible
*/
protected
function
doModifyLimitQuery
(
$query
,
$limit
,
$offset
)
{
if
(
$limit
!==
null
)
{
$query
.=
' LIMIT '
.
$limit
;
if
(
$offset
!==
null
)
{
$query
.=
' OFFSET '
.
$offset
;
}
}
elseif
(
$offset
!==
null
)
{
$query
.=
' LIMIT 18446744073709551615 OFFSET '
.
$offset
;
}
return
$query
;
}
/**
* {@inheritDoc}
*/
...
...
tests/Doctrine/Tests/DBAL/Platforms/MySqlPlatformTest.php
View file @
2dc589c5
...
...
@@ -17,6 +17,12 @@ class MySqlPlatformTest extends AbstractPlatformTestCase
return
new
MysqlPlatform
;
}
public
function
testModifyLimitQueryWitoutLimit
()
{
$sql
=
$this
->
_platform
->
modifyLimitQuery
(
'SELECT n FROM Foo'
,
null
,
10
);
$this
->
assertEquals
(
'SELECT n FROM Foo LIMIT 18446744073709551615 OFFSET 10'
,
$sql
);
}
public
function
testGenerateMixedCaseTableCreate
()
{
$table
=
new
Table
(
"Foo"
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment