Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
doctrine-dbal
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Tomáš Trávníček
doctrine-dbal
Commits
3e580007
Commit
3e580007
authored
Sep 09, 2013
by
dazz
Committed by
Benjamin Eberlei
Nov 13, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[DBAL-407] Added syntax error exception detection for sqlite driver
parent
2dd76c4a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
20 additions
and
0 deletions
+20
-0
DBALException.php
lib/Doctrine/DBAL/DBALException.php
+1
-0
Driver.php
lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php
+4
-0
ExceptionTest.php
tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php
+15
-0
No files found.
lib/Doctrine/DBAL/DBALException.php
View file @
3e580007
...
...
@@ -29,6 +29,7 @@ class DBALException extends \Exception
const
ERROR_BAD_FIELD_NAME
=
6
;
const
ERROR_NON_UNIQUE_FIELD_NAME
=
7
;
const
ERROR_NOT_UNIQUE
=
8
;
const
ERROR_SYNTAX
=
9
;
/**
* @param string $method
...
...
lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php
View file @
3e580007
...
...
@@ -148,6 +148,10 @@ class Driver implements \Doctrine\DBAL\Driver
if
(
strpos
(
$exception
->
getMessage
(),
'ambiguous column name'
)
!==
false
)
{
return
DBALException
::
ERROR_NON_UNIQUE_FIELD_NAME
;
}
if
(
strpos
(
$exception
->
getMessage
(),
'syntax error'
)
!==
false
)
{
return
DBALException
::
ERROR_SYNTAX
;
}
}
return
0
;
...
...
tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php
View file @
3e580007
...
...
@@ -141,6 +141,21 @@ class ExceptionTest extends \Doctrine\Tests\DbalFunctionalTestCase
$this
->
_conn
->
insert
(
"unique_field_table"
,
array
(
'id'
=>
5
));
}
public
function
testSyntaxErrorException
()
{
$table
=
new
\Doctrine\DBAL\Schema\Table
(
"syntax_error_table"
);
$table
->
addColumn
(
'id'
,
'integer'
,
array
());
$table
->
setPrimaryKey
(
array
(
'id'
));
foreach
(
$this
->
_conn
->
getDatabasePlatform
()
->
getCreateTableSQL
(
$table
)
AS
$sql
)
{
$this
->
_conn
->
executeQuery
(
$sql
);
}
$sql
=
'SELECT id FRO syntax_error_table'
;
$this
->
setExpectedException
(
'\Doctrine\DBAL\DBALException'
,
null
,
DBALException
::
ERROR_SYNTAX
);
$this
->
_conn
->
executeQuery
(
$sql
);
}
protected
function
onNotSuccessfulTest
(
\Exception
$e
)
{
parent
::
onNotSuccessfulTest
(
$e
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment