Commit 3f4cd46b authored by piccoloprincipe's avatar piccoloprincipe

[2.0] simplified removing code

parent 1b9b6c68
......@@ -59,9 +59,9 @@ class ECommerceCategory
public function removeProduct(ECommerceProduct $product)
{
if ($this->products->contains($product)) {
$this->products->removeElement($product);
$product->removeCategory($this);
$removed = $this->products->removeElement($product);
if ($removed !== null) {
$removed->removeCategory($this);
}
}
......
......@@ -98,12 +98,10 @@ class ECommerceProduct
public function removeFeature(ECommerceFeature $feature)
{
if ($this->features->contains($feature)) {
$removed = $this->features->removeElement($feature);
if ($removed) {
$feature->removeProduct();
return true;
}
$removed = $this->features->removeElement($feature);
if ($removed !== null) {
$removed->removeProduct();
return true;
}
return false;
}
......@@ -118,9 +116,9 @@ class ECommerceProduct
public function removeCategory(ECommerceCategory $category)
{
if ($this->categories->contains($category)) {
$this->categories->removeElement($category);
$category->removeProduct($this);
$removed = $this->categories->removeElement($category);
if ($removed !== null) {
$removed->removeProduct($this);
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment