Add testGivenForeignKeyWithZeroLength_acceptForeignKeyThrowsException

lib/Doctrine/DBAL/Schema/Visitor/DropSchemaSqlCollector.php

@@ -50,12 +50,12 @@ class DropSchemaSqlCollector extends AbstractVisitor
     private $tables;
 
     /**
-     * @var \Doctrine\DBAL\Platforms\AbstractPlatform
+     * @var AbstractPlatform
      */
     private $platform;
 
     /**
-     * @param \Doctrine\DBAL\Platforms\AbstractPlatform $platform
+     * @param AbstractPlatform $platform
      */
     public function __construct(AbstractPlatform $platform)
     {

tests/Doctrine/Tests/DBAL/Schema/Visitor/DropSchemaSqlCollectorTest.php

@@ -2,14 +2,17 @@
 
 namespace Doctrine\Tests\DBAL\Schema\Visitor;
 
-use \Doctrine\DBAL\Schema\Visitor\DropSchemaSqlCollector;
+use Doctrine\DBAL\Schema\Visitor\DropSchemaSqlCollector;
 
+/**
+ * @covers Doctrine\DBAL\Schema\Visitor\DropSchemaSqlCollector
+ */
 class DropSchemaSqlCollectorTest extends \PHPUnit_Framework_TestCase
 {
     public function testGetQueriesUsesAcceptedForeignKeys()
     {
-        $tableOne = $this->getMockWithoutArguments('Doctrine\DBAL\Schema\Table');
-        $tableTwo = $this->getMockWithoutArguments('Doctrine\DBAL\Schema\Table');
+        $tableOne = $this->getTableMock();
+        $tableTwo = $this->getTableMock();
 
         $keyConstraintOne = $this->getStubKeyConstraint('first');
         $keyConstraintTwo = $this->getStubKeyConstraint('second');
@@ -37,6 +40,11 @@ class DropSchemaSqlCollectorTest extends \PHPUnit_Framework_TestCase
         $collector->getQueries();
     }
 
+	private function getTableMock()
+	{
+		return $this->getMockWithoutArguments('Doctrine\DBAL\Schema\Table');
+	}
+
     private function getMockWithoutArguments($className)
     {
         return $this->getMockBuilder($className)->disableOriginalConstructor()->getMock();
@@ -46,10 +54,28 @@ class DropSchemaSqlCollectorTest extends \PHPUnit_Framework_TestCase
     {
         $constraint = $this->getMockWithoutArguments('Doctrine\DBAL\Schema\ForeignKeyConstraint');
 
-        $constraint->expects($this->any())
-            ->method('getName')
-            ->will($this->returnValue($name));
+		$constraint->expects($this->any())
+			->method('getName')
+			->will($this->returnValue($name));
+
+		$constraint->expects($this->any())
+			->method('getForeignColumns')
+			->will($this->returnValue(array()));
+
+		$constraint->expects($this->any())
+			->method('getColumns')
+			->will($this->returnValue(array()));
 
         return $constraint;
     }
+
+	public function testGivenForeignKeyWithZeroLength_acceptForeignKeyThrowsException()
+	{
+		$collector = new DropSchemaSqlCollector(
+			$this->getMockForAbstractClass('Doctrine\DBAL\Platforms\AbstractPlatform')
+		);
+
+		$this->setExpectedException( 'Doctrine\DBAL\Schema\SchemaException' );
+		$collector->acceptForeignKey($this->getTableMock(), $this->getStubKeyConstraint(''));
+	}
 }