Unverified Commit 4d461200 authored by Sergei Morozov's avatar Sergei Morozov Committed by GitHub

Merge pull request #4090 from morozov/oracle-create-null-database

Make the $database argument of OracleSchemaManager::createDatabase() mandatory
parents 20f2deed 78c91633
# Upgrade to 3.0 # Upgrade to 3.0
## BC BREAK: Changes in `OracleSchemaManager::createDatabase()`
The `$database` argument is no longer nullable or optional.
## BC BREAK: `Doctrine\DBAL\Types\Type::__toString()` removed ## BC BREAK: `Doctrine\DBAL\Types\Type::__toString()` removed
Relying on string representation was discouraged and has been removed. Relying on string representation was discouraged and has been removed.
......
...@@ -279,17 +279,9 @@ class OracleSchemaManager extends AbstractSchemaManager ...@@ -279,17 +279,9 @@ class OracleSchemaManager extends AbstractSchemaManager
/** /**
* {@inheritdoc} * {@inheritdoc}
*
* @param string|null $database
*
* Calling this method without an argument or by passing NULL is deprecated.
*/ */
public function createDatabase($database = null) public function createDatabase($database)
{ {
if ($database === null) {
$database = $this->_conn->getDatabase();
}
$params = $this->_conn->getParams(); $params = $this->_conn->getParams();
$username = $database; $username = $database;
$password = $params['password']; $password = $params['password'];
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment