Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
doctrine-dbal
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Tomáš Trávníček
doctrine-dbal
Commits
78c91633
Unverified
Commit
78c91633
authored
Jun 18, 2020
by
Sergei Morozov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make the $database argument of OracleSchemaManager::createDatabase() mandatory
parent
e33c76a6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
9 deletions
+5
-9
UPGRADE.md
UPGRADE.md
+4
-0
OracleSchemaManager.php
src/Schema/OracleSchemaManager.php
+1
-9
No files found.
UPGRADE.md
View file @
78c91633
# Upgrade to 3.0
## BC BREAK: Changes in `OracleSchemaManager::createDatabase()`
The
`$database`
argument is no longer nullable or optional.
## BC BREAK: `Doctrine\DBAL\Types\Type::__toString()` removed
Relying on string representation was discouraged and has been removed.
...
...
src/Schema/OracleSchemaManager.php
View file @
78c91633
...
...
@@ -279,17 +279,9 @@ class OracleSchemaManager extends AbstractSchemaManager
/**
* {@inheritdoc}
*
* @param string|null $database
*
* Calling this method without an argument or by passing NULL is deprecated.
*/
public
function
createDatabase
(
$database
=
null
)
public
function
createDatabase
(
$database
)
{
if
(
$database
===
null
)
{
$database
=
$this
->
_conn
->
getDatabase
();
}
$params
=
$this
->
_conn
->
getParams
();
$username
=
$database
;
$password
=
$params
[
'password'
];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment