Merge pull request #3481 from morozov/phpstan-0.11.3

Updated PHPStan to v0.11.3

composer.json

@@ -29,7 +29,7 @@
     "require-dev": {
         "doctrine/coding-standard": "^5.0",
         "jetbrains/phpstorm-stubs": "^2018.1.2",
-        "phpstan/phpstan": "^0.11.1",
+        "phpstan/phpstan": "^0.11.3",
         "phpunit/phpunit": "^8.0",
         "symfony/console": "^2.0.5|^3.0|^4.0",
         "symfony/phpunit-bridge": "^3.4.5|^4.0.5"

lib/Doctrine/DBAL/Driver/SQLAnywhere/SQLAnywhereException.php

@@ -4,7 +4,6 @@ namespace Doctrine\DBAL\Driver\SQLAnywhere;
 
 use Doctrine\DBAL\Driver\AbstractDriverException;
 use InvalidArgumentException;
-use function is_resource;
 use function sasql_error;
 use function sasql_errorcode;
 use function sasql_sqlstate;
@@ -28,14 +27,6 @@ class SQLAnywhereException extends AbstractDriverException
      */
     public static function fromSQLAnywhereError($conn = null, $stmt = null)
     {
-        if ($conn !== null && ! is_resource($conn)) {
-            throw new InvalidArgumentException('Invalid SQL Anywhere connection resource given: ' . $conn);
-        }
-
-        if ($stmt !== null && ! is_resource($stmt)) {
-            throw new InvalidArgumentException('Invalid SQL Anywhere statement resource given: ' . $stmt);
-        }
-
         $state   = $conn ? sasql_sqlstate($conn) : sasql_sqlstate();
         $code    = null;
         $message = null;

lib/Doctrine/DBAL/Event/SchemaDropTableEventArgs.php

@@ -5,7 +5,6 @@ namespace Doctrine\DBAL\Event;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\Table;
 use InvalidArgumentException;
-use function is_string;
 
 /**
  * Event Arguments used when the SQL query for dropping tables are generated inside Doctrine\DBAL\Platform\AbstractPlatform.
@@ -28,10 +27,6 @@ class SchemaDropTableEventArgs extends SchemaEventArgs
      */
     public function __construct($table, AbstractPlatform $platform)
     {
-        if (! $table instanceof Table && ! is_string($table)) {
-            throw new InvalidArgumentException('SchemaDropTableEventArgs expects $table parameter to be string or \Doctrine\DBAL\Schema\Table.');
-        }
-
         $this->table    = $table;
         $this->platform = $platform;
     }

lib/Doctrine/DBAL/Platforms/DrizzlePlatform.php

@@ -576,7 +576,7 @@ class DrizzlePlatform extends AbstractPlatform
     {
         if (is_array($item)) {
             foreach ($item as $key => $value) {
-                if (! is_bool($value) && ! is_numeric($item)) {
+                if (! is_bool($value) && ! is_numeric($value)) {
                     continue;
                 }
 

lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php

@@ -1399,7 +1399,7 @@ SQL
     {
         if (is_array($item)) {
             foreach ($item as $key => $value) {
-                if (! is_bool($value) && ! is_numeric($item)) {
+                if (! is_bool($value) && ! is_numeric($value)) {
                     continue;
                 }
 

lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php

@@ -947,9 +947,9 @@ abstract class AbstractSchemaManager
     }
 
     /**
-     * @param mixed[] $user
+     * @param string[] $user
      *
-     * @return mixed[]
+     * @return string[]
      */
     protected function _getPortableUserDefinition($user)
     {