DBAL-62 - There is a diference between maximum length (now 4000, oracle is the...

DBAL-62 - There is a diference between maximum length (now 4000, oracle is the smallest possible denominator here) of varchars and the default length (255).

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

@@ -245,6 +245,16 @@ abstract class AbstractPlatform
      * @return integer
      */
     public function getVarcharMaxLength()
+    {
+        return 4000;
+    }
+
+    /**
+     * Gets the default length of a varchar field.
+     *
+     * @return integer
+     */
+    public function getVarcharDefaultLength()
     {
         return 255;
     }

lib/Doctrine/DBAL/Platforms/DB2Platform.php

@@ -52,7 +52,7 @@ class DB2Platform extends AbstractPlatform
     {
         if ( ! isset($field['length'])) {
             if (array_key_exists('default', $field)) {
-                $field['length'] = $this->getVarcharMaxLength();
+                $field['length'] = $this->getVarcharDefaultLength();
             } else {
                 $field['length'] = false;
             }

lib/Doctrine/DBAL/Platforms/MsSqlPlatform.php

@@ -543,7 +543,7 @@ class MsSqlPlatform extends AbstractPlatform
     {
         if (!isset($field['length'])) {
             if (array_key_exists('default', $field)) {
-                $field['length'] = $this->getVarcharMaxLength();
+                $field['length'] = $this->getVarcharDefaultLength();
             } else {
                 $field['length'] = false;
             }

lib/Doctrine/DBAL/Platforms/MySqlPlatform.php

@@ -156,7 +156,7 @@ class MySqlPlatform extends AbstractPlatform
     {
         if ( ! isset($field['length'])) {
             if (array_key_exists('default', $field)) {
-                $field['length'] = $this->getVarcharMaxLength();
+                $field['length'] = $this->getVarcharDefaultLength();
             } else {
                 $field['length'] = false;
             }

lib/Doctrine/DBAL/Platforms/OraclePlatform.php

@@ -238,7 +238,7 @@ class OraclePlatform extends AbstractPlatform
     {
         if ( ! isset($field['length'])) {
             if (array_key_exists('default', $field)) {
-                $field['length'] = $this->getVarcharMaxLength();
+                $field['length'] = $this->getVarcharDefaultLength();
             } else {
                 $field['length'] = false;
             }

lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php

@@ -595,7 +595,7 @@ class PostgreSqlPlatform extends AbstractPlatform
     {
         if ( ! isset($field['length'])) {
             if (array_key_exists('default', $field)) {
-                $field['length'] = $this->getVarcharMaxLength();
+                $field['length'] = $this->getVarcharDefaultLength();
             } else {
                 $field['length'] = false;
             }

lib/Doctrine/DBAL/Platforms/SqlitePlatform.php

@@ -304,7 +304,7 @@ class SqlitePlatform extends AbstractPlatform
     {
         if ( ! isset($field['length'])) {
             if (array_key_exists('default', $field)) {
-                $field['length'] = $this->getVarcharMaxLength();
+                $field['length'] = $this->getVarcharDefaultLength();
             } else {
                 $field['length'] = false;
             }