#869 - DBAL-1293 - `DateIntervalType` should throw on invalid types

lib/Doctrine/DBAL/Types/DateIntervalType.php

@@ -33,20 +33,17 @@ class DateIntervalType extends Type
      */
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
     {
-        $spec = null;
-        if ($value !== null) {
-            /** @var \DateInterval $value */
-            $spec = 'P'
+        if (null === $value) {
+            return null;
+        }
+
+        if ($value instanceof \DateInterval) {
+            return 'P'
                 . str_pad($value->y, 4, '0', STR_PAD_LEFT) . '-'
-                . $value->format('%M') . '-'
-                . $value->format('%D') . 'T'
-                . $value->format('%H') . ':'
-                . $value->format('%I') . ':'
-                . $value->format('%S')
-            ;
+                . $value->format('%M-%DT%H:%I:%S');
         }
 
-        return $spec;
+        throw ConversionException::conversionFailedInvalidType($value, $this->getName(), ['null', 'DateInterval']);
     }
 
     /**