Merge pull request #4134 from morozov/deprecate-some-dbal-exception-methods

Deprecate some DBALException factory methods

UPGRADE.md

 # Upgrade to 2.11
 
+## `DBALException` factory method deprecations
+
+1. `DBALException::invalidPlatformType()` is deprecated as unused as of v2.7.0.
+2. `DBALException::invalidPdoInstance()` as passing a PDO instance via configuration is deprecated.
+
 ## `AbstractPlatform::fixSchemaElementName()` is deprecated.
 
 The method is not used anywhere except for tests.

lib/Doctrine/DBAL/DBALException.php

@@ -38,6 +38,9 @@ class DBALException extends Exception
         return new self(sprintf("Operation '%s' is not supported by platform.", $method));
     }
 
+    /**
+     * @deprecated Use {@link invalidPlatformType()} instead.
+     */
     public static function invalidPlatformSpecified(): self
     {
         return new self(
@@ -90,6 +93,8 @@ class DBALException extends Exception
     }
 
     /**
+     * @deprecated Passing a PDO instance in connection parameters is deprecated.
+     *
      * @return DBALException
      */
     public static function invalidPdoInstance()