PDO APIs need additional assertions due to the existing error suppression mode

abb6800d · Sergei Morozov · 52a91a37 · abb6800d
Unverified Commit abb6800d authored Jun 19, 2020 by Sergei Morozov
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

PDOConnection.php lib/Doctrine/DBAL/Driver/PDOConnection.php +4 -1

No files found.
--- a/lib/Doctrine/DBAL/Driver/PDOConnection.php
+++ b/lib/Doctrine/DBAL/Driver/PDOConnection.php
@@ -38,7 +38,10 @@ class PDOConnection extends PDO implements Connection, ServerInfoAwareConnection
    public function exec($statement)
    {
        try {
-            return parent::exec($statement);
+            $result = parent::exec($statement);
+            assert($result !== false);
+
+            return $result;
        } catch (\PDOException $exception) {
            throw new PDOException($exception);
        }