DBAL-17 - Fix notice when relying on enviroment variable to determine Oracle Database

b170b3b4 · Benjamin Eberlei · c9041d60 · b170b3b4
Commit b170b3b4 authored Jun 28, 2010 by Benjamin Eberlei
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

Driver.php lib/Doctrine/DBAL/Driver/OCI8/Driver.php +5 -1

No files found.
--- a/lib/Doctrine/DBAL/Driver/OCI8/Driver.php
+++ b/lib/Doctrine/DBAL/Driver/OCI8/Driver.php
@@ -58,7 +58,11 @@ class Driver implements \Doctrine\DBAL\Driver
                $dsn .= '(PORT=1521)';
            }

-            $dsn .= '))(CONNECT_DATA=(SID=' . $params['dbname'] . ')))';
+            $dsn .= '))';
+            if (isset($params['dbname'])) {
+                $dsn .= '(CONNECT_DATA=(SID=' . $params['dbname'] . ')';
+            }
+            $dsn .= '))';
        } else {
            $dsn .= $params['dbname'];
        }