Merge pull request #3598 from morozov/deprecate-unused

Deprecated some unused code bits

UPGRADE.md

 # Upgrade to 2.10
 
+## Deprecated `Doctrine\DBAL\Platforms::_getAlterTableIndexForeignKeySQL()`
+
+Method `Doctrine\DBAL\Platforms::_getAlterTableIndexForeignKeySQL()` has been deprecated as no longer used.
+
+## Deprecated `Doctrine\DBAL\Driver\OCI8\OCI8Statement::$_PARAM`
+
+Property `Doctrine\DBAL\Driver\OCI8\OCI8Statement::$_PARAM` has been deprecated as not used.
+
 ## Deprecated `Doctrine\DBAL\Driver::getName()`
 
 Relying on the name of the driver is discouraged. For referencing the driver, use its class name.

lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php

@@ -58,7 +58,11 @@ class OCI8Statement implements IteratorAggregate, Statement
     /** @var OCI8Connection */
     protected $_conn;
 
-    /** @var string */
+    /**
+     * @deprecated
+     *
+     * @var string
+     */
     protected static $_PARAM = ':param';
 
     /** @var int[] */

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

@@ -2140,6 +2140,8 @@ abstract class AbstractPlatform
     /**
      * Common code for alter table statement generation that updates the changed Index and Foreign Key definitions.
      *
+     * @deprecated
+     *
      * @return string[]
      */
     protected function _getAlterTableIndexForeignKeySQL(TableDiff $diff)