Added some more code coverage, removed unnecessary condition

lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php

@@ -151,10 +151,7 @@ class OCI8Statement implements \IteratorAggregate, Statement
             ));
         }
 
-        if ($fragmentOffset < strlen($statement)) {
-            $fragments[] = substr($statement, $fragmentOffset);
-        }
-
+        $fragments[] = substr($statement, $fragmentOffset);
         $statement = implode('', $fragments);
 
         return array($statement, $paramMap);

tests/Doctrine/Tests/DBAL/Driver/OCI8/OCI8StatementTest.php

@@ -113,24 +113,18 @@ class OCI8StatementTest extends DbalTestCase
                 "INSERT INTO table (col1, col2, col3, col4) VALUES('?\"?\'?', :param1, \"?'?\\\"?\", :param2)",
                 2,
             ),
+            'placeholder-at-the-end' => array(
+                "SELECT id FROM table WHERE col = ?",
+                "SELECT id FROM table WHERE col = :param1",
+                1,
+            ),
         );
     }
 
-    /**
-     * @dataProvider convertFailureProvider
-     */
-    public function testConvertFailure($statement)
+    public function testConvertNonTerminatedLiteral()
     {
         $this->expectException(OCI8Exception::class);
-        OCI8Statement::convertPositionalToNamedPlaceholders($statement);
-    }
-
-    public static function convertFailureProvider()
-    {
-        return array(
-            'non-terminated-literal' => array(
-                'SELECT "literal',
-            ),
-        );
+        $this->expectExceptionMessageRegExp('/offset 7/');
+        OCI8Statement::convertPositionalToNamedPlaceholders('SELECT "literal');
     }
 }