Merge pull request #2634 from deeky666/fix-sqlserver-sequence-last-insert-id

Fix fetching last insert ID for sequences on SQL Server

lib/Doctrine/DBAL/Driver/PDOSqlsrv/Connection.php

@@ -37,6 +37,21 @@ class Connection extends PDOConnection implements \Doctrine\DBAL\Driver\Connecti
         $this->setAttribute(\PDO::ATTR_STATEMENT_CLASS, array(Statement::class, array()));
     }
 
+    /**
+     * {@inheritDoc}
+     */
+    public function lastInsertId($name = null)
+    {
+        if (null === $name) {
+            return parent::lastInsertId($name);
+        }
+
+        $stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
+        $stmt->execute(array($name));
+
+        return $stmt->fetchColumn();
+    }
+
     /**
      * {@inheritDoc}
      */

lib/Doctrine/DBAL/Driver/SQLSrv/SQLSrvConnection.php

@@ -130,9 +130,8 @@ class SQLSrvConnection implements Connection, ServerInfoAwareConnection
     public function lastInsertId($name = null)
     {
         if ($name !== null) {
-            $sql = "SELECT IDENT_CURRENT(".$this->quote($name).") AS LastInsertId";
-            $stmt = $this->prepare($sql);
-            $stmt->execute();
+            $stmt = $this->prepare('SELECT CONVERT(VARCHAR(MAX), current_value) FROM sys.sequences WHERE name = ?');
+            $stmt->execute(array($name));
 
             return $stmt->fetchColumn();
         }