Merge pull request #3794 from BenMorel/sqlite-fk

Support ForeignKeyConstraintViolationException in SQLite

lib/Doctrine/DBAL/Driver/AbstractSQLiteDriver.php

@@ -39,6 +39,10 @@ abstract class AbstractSQLiteDriver implements Driver, ExceptionConverterDriver
             return new Exception\UniqueConstraintViolationException($message, $exception);
         }
 
+        if (strpos($exception->getMessage(), 'FOREIGN KEY constraint failed') !== false) {
+            return new Exception\ForeignKeyConstraintViolationException($message, $exception);
+        }
+
         if (strpos($exception->getMessage(), 'may not be NULL') !== false ||
             strpos($exception->getMessage(), 'NOT NULL constraint failed') !== false
         ) {

tests/Doctrine/Tests/DBAL/Driver/AbstractSQLiteDriverTest.php

@@ -64,6 +64,9 @@ class AbstractSQLiteDriverTest extends AbstractDriverTest
                 [0, null, 'is not unique'],
                 [0, null, 'are not unique'],
             ],
+            self::EXCEPTION_FOREIGN_KEY_CONSTRAINT_VIOLATION => [
+                [0, null, 'FOREIGN KEY constraint failed'],
+            ],
             self::EXCEPTION_LOCK_WAIT_TIMEOUT => [
                 [0, null, 'database is locked'],
             ],

tests/Doctrine/Tests/DBAL/Functional/ExceptionTest.php

@@ -78,7 +78,11 @@ class ExceptionTest extends DbalFunctionalTestCase
 
     public function testForeignKeyConstraintViolationExceptionOnInsert() : void
     {
-        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if ($platform instanceof SqlitePlatform) {
+            $this->connection->exec('PRAGMA foreign_keys = ON');
+        } elseif (! $platform->supportsForeignKeyConstraints()) {
             $this->markTestSkipped('Only fails on platforms with foreign key constraints.');
         }
 
@@ -112,7 +116,11 @@ class ExceptionTest extends DbalFunctionalTestCase
 
     public function testForeignKeyConstraintViolationExceptionOnUpdate() : void
     {
-        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if ($platform instanceof SqlitePlatform) {
+            $this->connection->exec('PRAGMA foreign_keys = ON');
+        } elseif (! $platform->supportsForeignKeyConstraints()) {
             $this->markTestSkipped('Only fails on platforms with foreign key constraints.');
         }
 
@@ -146,7 +154,11 @@ class ExceptionTest extends DbalFunctionalTestCase
 
     public function testForeignKeyConstraintViolationExceptionOnDelete() : void
     {
-        if (! $this->connection->getDatabasePlatform()->supportsForeignKeyConstraints()) {
+        $platform = $this->connection->getDatabasePlatform();
+
+        if ($platform instanceof SqlitePlatform) {
+            $this->connection->exec('PRAGMA foreign_keys = ON');
+        } elseif (! $platform->supportsForeignKeyConstraints()) {
             $this->markTestSkipped('Only fails on platforms with foreign key constraints.');
         }
 
@@ -182,7 +194,9 @@ class ExceptionTest extends DbalFunctionalTestCase
     {
         $platform = $this->connection->getDatabasePlatform();
 
-        if (! $platform->supportsForeignKeyConstraints()) {
+        if ($platform instanceof SqlitePlatform) {
+            $this->connection->exec('PRAGMA foreign_keys = ON');
+        } elseif (! $platform->supportsForeignKeyConstraints()) {
             $this->markTestSkipped('Only fails on platforms with foreign key constraints.');
         }