minor refactorings & cleanups.

lib/Doctrine/Mapper.php

@@ -354,7 +354,6 @@ class Doctrine_Mapper
                 return $record;
             }
 
-
             $idHash = $this->_conn->unitOfWork->getIdentifierHash($id);
 
             if ($record = $this->_conn->unitOfWork->tryGetByIdHash($idHash,
@@ -374,6 +373,7 @@ class Doctrine_Mapper
 
     /**
      * @param $id                       database row id
+     * @todo Looks broken. Figure out an implementation and decide whether its needed.
      */
     final public function getProxy($id = null)
     {
@@ -544,16 +544,6 @@ class Doctrine_Mapper
     {
         return $this->_domainClassName;
     }
-
-    /**
-     * returns a string representation of this object
-     *
-     * @return string
-     */
-    /*public function __toString()
-    {
-        return Doctrine_Lib::getTableAsString($this);
-    }*/
     
     /**
      * findBy

lib/Doctrine/Pager.php

@@ -30,6 +30,7 @@
  * @version     $Revision$
  * @link        www.phpdoctrine.org
  * @since       0.9
+ * @todo Move the Pager into a separate package ("Doctrine Utilities"? or even a "Doctrine Pager" package?)
  */
 class Doctrine_Pager
 {

lib/Doctrine/Sequence/Db2.php

@@ -18,7 +18,7 @@
  * and is licensed under the LGPL. For more information, see
  * <http://www.phpdoctrine.org>.
  */
-Doctrine::autoload('Doctrine_Sequence');
+
 /**
  * Doctrine_Sequence_Db2
  *

lib/Doctrine/Sequence/Firebird.php

@@ -18,7 +18,7 @@
  * and is licensed under the LGPL. For more information, see
  * <http://www.phpdoctrine.org>.
  */
-Doctrine::autoload('Doctrine_Sequence');
+
 /**
  * Doctrine_Sequence_Firebird
  *
@@ -33,7 +33,7 @@ Doctrine::autoload('Doctrine_Sequence');
 class Doctrine_Sequence_Firebird extends Doctrine_Sequence
 {
     /**
-     * Returns the next free id of a sequence
+     * Returns the next free id of a sequence.
      *
      * @param string $seqName   name of the sequence
      * @param bool              when true missing sequences are automatic created

lib/Doctrine/Sequence/Mssql.php

@@ -18,7 +18,7 @@
  * and is licensed under the LGPL. For more information, see
  * <http://www.phpdoctrine.org>.
  */
-Doctrine::autoload('Doctrine_Sequence');
+
 /**
  * Doctrine_Sequence_Mssql
  *

lib/Doctrine/Sequence/Mysql.php

@@ -18,7 +18,7 @@
  * and is licensed under the LGPL. For more information, see
  * <http://www.phpdoctrine.org>.
  */
-Doctrine::autoload('Doctrine_Sequence');
+
 /**
  * Doctrine_Sequence_Mysql
  *

lib/Doctrine/Sequence/Oracle.php

@@ -18,7 +18,7 @@
  * and is licensed under the LGPL. For more information, see
  * <http://www.phpdoctrine.org>.
  */
-Doctrine::autoload('Doctrine_Sequence');
+
 /**
  * Doctrine_Sequence_Oracle
  *

lib/Doctrine/Sequence/Pgsql.php

@@ -18,7 +18,7 @@
  * and is licensed under the LGPL. For more information, see
  * <http://www.phpdoctrine.org>.
  */
-Doctrine::autoload('Doctrine_Sequence');
+
 /**
  * Doctrine_Sequence_Pgsql
  *

lib/Doctrine/Sequence/Sqlite.php

@@ -33,7 +33,7 @@
 class Doctrine_Sequence_Sqlite extends Doctrine_Sequence
 {
     /**
-     * Returns the next free id of a sequence
+     * Returns the next free id of a sequence.
      *
      * @param string $seqName   name of the sequence
      * @param bool $onDemand    when true missing sequences are automatic created
@@ -48,9 +48,7 @@ class Doctrine_Sequence_Sqlite extends Doctrine_Sequence
         $query = 'INSERT INTO ' . $sequenceName . ' (' . $seqcolName . ') VALUES (NULL)';
 
         try {
-
-            $num = $this->conn->exec($query);
-
+            $this->conn->exec($query);
         } catch (Doctrine_Connection_Exception $e) {
             if ($onDemand && $e->getPortableCode() == Doctrine::ERR_NOSUCHTABLE) {
                 try {