1. 28 Jun, 2020 1 commit
  2. 27 Jun, 2020 1 commit
    • Sergei Morozov's avatar
      Remove ServerInfoAwareConnection#requiresQueryForServerVersion() as an implementation detail · b98abf0a
      Sergei Morozov authored
      Testing the implementations of this method requires partial mocking of the implementing class which makes it impossible to make them `final` (#3590).
      
      Additionally, this API breaks the encapsulation of the driver layer: instead of exposing the fact of whether the connection will perform a query to detect the server version, the driver should just instantiate a platform corresponding to a connection.
      
      The rationale behind introducing this method (#487) is really questionable:
      
      > This is also required for drivers that cannot return the database server version without an additional query (performance reasons).
      
      1. There's no evidence that an underlying driver that exposes the server version via its API doesn't make a request of any kind to the server.
      2. For an application that works with any realistic database, a query like `SELECT VERSION()` wouldn't be a performance bottleneck.
      3. Even if it was, it's always possible to specify the platform version upfront. Otherwise, the current logic of falling back to a default platform may cause undefined behavior of the application (we don't test the compatibility of the lowest level of the DBAL platform with all supported server versions). Remember, “If it doesn’t work, it doesn’t matter how fast it doesn’t work.”
      b98abf0a
  3. 17 Jun, 2020 4 commits
  4. 13 Jun, 2020 1 commit
  5. 09 Jun, 2020 1 commit
  6. 27 May, 2020 3 commits
  7. 13 Apr, 2020 1 commit
    • Sergei Morozov's avatar
      Dropped support for fetching objects and non-zero column · aa6ae1d6
      Sergei Morozov authored
      1. `FetchMode::STANDARD_OBJECT` and `FetchMode::CUSTOM_OBJECT` are no longer supported.
      2. `FetchMode::COLUMN` with a non-zero index is no longer supported.
      3. Incompatible change in the `Connection::fetchColumn()` signature where the 3rd argument is now `$types`, not `$columnIndex`.
      aa6ae1d6
  8. 08 Apr, 2020 2 commits
  9. 21 Mar, 2020 1 commit
  10. 30 Dec, 2019 3 commits
  11. 31 Oct, 2019 1 commit
  12. 14 Oct, 2019 1 commit
  13. 26 Jun, 2019 1 commit
  14. 22 May, 2019 1 commit
  15. 17 Apr, 2019 1 commit
  16. 17 Mar, 2019 1 commit
  17. 03 Feb, 2019 1 commit
  18. 29 Jan, 2019 1 commit
  19. 22 Jan, 2019 1 commit
  20. 20 Jan, 2019 1 commit
  21. 07 Oct, 2018 1 commit
  22. 02 Oct, 2018 4 commits
  23. 27 Jun, 2018 1 commit
  24. 01 Apr, 2018 1 commit
  25. 29 Jan, 2018 5 commits