1. 01 Oct, 2013 2 commits
    • flip111's avatar
      Put back some old code and fixed test case. · c6b4ff21
      flip111 authored
      Apperently the doModifyLimitQuery function does not only cover SQL
      generated by ORM (Makes sense to use DBAL as seperate component). Therefor
      it can happen that a column name does not include the table and so the old
      logic was valid anyway. (line 867-869)
      
      Fixed the unit tests to use real column names instead of aliases.
      c6b4ff21
    • flip111's avatar
      Made cleaner code and remove unneccessary checks. · 75048b21
      flip111 authored
      1. combine the regexes into one. The only thing that needs to be captured
      is the alias. Used a non-capturing group for "AS " to avoid confusion and
      have cleaner regex. It tries to match "Table.Column Alias" or
      "Table.Column AS Alias". (line 861)
      2. No fallback on line 865 like "$column['table'] . '.' .
      $column['column']" this wouldn't make sense as this can not be possible
      when it's a wrapped query. Better not insert some random SQL that's gonna
      confuse the hell out of everybody.
      3. Removed "($column['hasTable'] ? $column['table']  . '.' : '') .
      $column['column']" because the original regex always tries to match the
      table name. Therefor hasTable will always be true or the entire function
      fails anyway. (this references line 868 now) (this was unit tested on
      mysql, postgresql and sql server and did not increase errors/failures)
      75048b21
  2. 30 Sep, 2013 1 commit
  3. 15 Sep, 2013 2 commits
  4. 12 Sep, 2013 2 commits
  5. 08 Sep, 2013 1 commit
  6. 07 Sep, 2013 1 commit
    • Benjamin Eberlei's avatar
      New build process · 2ebae44b
      Benjamin Eberlei authored
      - Switch from phing to ant
      - Add composer archive for packages
      - Remove PEAR package building
      2ebae44b
  7. 06 Sep, 2013 1 commit
  8. 05 Sep, 2013 2 commits
  9. 24 Aug, 2013 1 commit
  10. 23 Aug, 2013 1 commit
  11. 10 Aug, 2013 2 commits
  12. 09 Aug, 2013 4 commits
  13. 06 Aug, 2013 9 commits
  14. 03 Aug, 2013 2 commits
  15. 31 Jul, 2013 2 commits
  16. 29 Jul, 2013 3 commits
  17. 24 Jul, 2013 3 commits
  18. 01 Jul, 2013 1 commit