- 30 Jan, 2020 1 commit
-
-
Benjamin Morel authored
-
- 29 Jan, 2020 1 commit
-
-
Benjamin Morel authored
-
- 28 Jan, 2020 2 commits
-
-
Benjamin Morel authored
-
Benjamin Morel authored
-
- 27 Jan, 2020 1 commit
-
-
Benjamin Morel authored
-
- 26 Jan, 2020 2 commits
-
-
Sergei Morozov authored
-
Sergei Morozov authored
-
- 25 Jan, 2020 3 commits
-
-
Benjamin Morel authored
-
Benjamin Morel authored
-
Benjamin Morel authored
-
- 22 Jan, 2020 1 commit
-
-
Sergei Morozov authored
The original signature was improperly documented which later became enforced.
-
- 21 Jan, 2020 2 commits
-
-
Sergei Morozov authored
-
Benjamin Morel authored
-
- 17 Jan, 2020 1 commit
-
-
Benjamin Morel authored
-
- 16 Jan, 2020 2 commits
-
-
Sergei Morozov authored
-
Sergei Morozov authored
-
- 15 Jan, 2020 1 commit
-
-
Benjamin Morel authored
-
- 13 Jan, 2020 1 commit
-
-
Sergei Morozov authored
The existing relationship between the connection and its statement violate the ISP principle. Instead of having access only to the execution mode of the connection, statements have access to the entire connection API. Having a method which is not defined in the driver connection interface makes it impossible to mark the method `final` (#3590).
-
- 12 Jan, 2020 2 commits
-
-
Sergei Morozov authored
-
Sergei Morozov authored
-
- 11 Jan, 2020 1 commit
-
-
Jonathan H. Wage authored
-
- 08 Jan, 2020 2 commits
-
-
Sergei Morozov authored
-
Sergei Morozov authored
-
- 03 Jan, 2020 2 commits
-
-
Benjamin Morel authored
-
Sergei Morozov authored
Testing the implementations of this method requires partial mocking of the implementing class which makes it impossible to make them `final` (#3590). Additionally, this API breaks the encapsulation of the driver layer: instead of exposing the fact of whether the connection will perform a query to detect the server version, the driver should just instantiate a platform corresponding to a connection. The rationale behind introducing this method (#487) is really questionable: > This is also required for drivers that cannot return the database server version without an additional query (performance reasons). 1. There's no evidence that an underlying driver that exposes the server version via its API doesn't make a request of any kind to the server. 2. For an application that works with any realistic database, a query like `SELECT VERSION()` wouldn't be a performance bottleneck. 3. Even if it was, it's always possible to specify the platform version upfront. Otherwise, the current logic of falling back to a default platform may cause undefined behavior of the application (we don't test the compatibility of the lowest level of the DBAL platform with all supported server versions). Remember, “If it doesn’t work, it doesn’t matter how fast it doesn’t work.” In addition to the above, the only driver that doesn't support the platform version detection via the underlying driver API is `sqsql` which is barely supported.
-
- 31 Dec, 2019 1 commit
-
-
Jonathan H. Wage authored
-
- 30 Dec, 2019 8 commits
-
-
Sergei Morozov authored
-
Sergei Morozov authored
-
Sergei Morozov authored
-
Sergei Morozov authored
-
Sergei Morozov authored
-
Benjamin Morel authored
-
Benjamin Morel authored
-
Benjamin Morel authored
-
- 29 Dec, 2019 1 commit
-
-
S38151 authored
-
- 23 Dec, 2019 2 commits
-
-
Benjamin Morel authored
-
Benjamin Morel authored
-
- 21 Dec, 2019 1 commit
-
-
Alexander Rakushin authored
-
- 19 Dec, 2019 1 commit
-
-
Sergei Morozov authored
-
- 16 Dec, 2019 1 commit
-
-
Christoph Wurst authored
Signed-off-by:
Christoph Wurst <christoph@winzerhof-wurst.at>
-