Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
D
doctrine-dbal
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Tomáš Trávníček
doctrine-dbal
Commits
31195d92
Unverified
Commit
31195d92
authored
Apr 20, 2017
by
James Titcumb
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Corrections from PR review for DB2SchemaManager and related test
parent
da1d4c16
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
4 deletions
+7
-4
DB2SchemaManager.php
lib/Doctrine/DBAL/Schema/DB2SchemaManager.php
+1
-3
DB2SchemaManagerTest.php
tests/Doctrine/Tests/DBAL/Schema/DB2SchemaManagerTest.php
+6
-1
No files found.
lib/Doctrine/DBAL/Schema/DB2SchemaManager.php
View file @
31195d92
...
...
@@ -41,9 +41,7 @@ class DB2SchemaManager extends AbstractSchemaManager
$tables
=
$this
->
_conn
->
fetchAll
(
$sql
);
$tableNames
=
$this
->
_getPortableTablesList
(
$tables
);
return
$this
->
filterAssetNames
(
$tableNames
);
return
$this
->
filterAssetNames
(
$this
->
_getPortableTablesList
(
$tables
));
}
/**
...
...
tests/Doctrine/Tests/DBAL/Schema/DB2SchemaManagerTest.php
View file @
31195d92
...
...
@@ -15,7 +15,7 @@ use Doctrine\DBAL\Schema\DB2SchemaManager;
final
class
DB2SchemaManagerTest
extends
\PHPUnit_Framework_TestCase
{
/**
* @var Connection
* @var Connection
|\PHPUnit_Framework_MockObject_MockObject
*/
private
$conn
;
...
...
@@ -37,6 +37,11 @@ final class DB2SchemaManagerTest extends \PHPUnit_Framework_TestCase
$this
->
manager
=
new
DB2SchemaManager
(
$this
->
conn
);
}
/**
* @group DBAL-2701
* @see https://github.com/doctrine/dbal/issues/2701
* @return void
*/
public
function
testListTableNamesFiltersAssetNamesCorrectly
()
{
$this
->
conn
->
getConfiguration
()
->
setFilterSchemaAssetsExpression
(
'/^(?!T_)/'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment