Corrections from PR review for DB2SchemaManager and related test

parent da1d4c16
...@@ -41,9 +41,7 @@ class DB2SchemaManager extends AbstractSchemaManager ...@@ -41,9 +41,7 @@ class DB2SchemaManager extends AbstractSchemaManager
$tables = $this->_conn->fetchAll($sql); $tables = $this->_conn->fetchAll($sql);
$tableNames = $this->_getPortableTablesList($tables); return $this->filterAssetNames($this->_getPortableTablesList($tables));
return $this->filterAssetNames($tableNames);
} }
/** /**
......
...@@ -15,7 +15,7 @@ use Doctrine\DBAL\Schema\DB2SchemaManager; ...@@ -15,7 +15,7 @@ use Doctrine\DBAL\Schema\DB2SchemaManager;
final class DB2SchemaManagerTest extends \PHPUnit_Framework_TestCase final class DB2SchemaManagerTest extends \PHPUnit_Framework_TestCase
{ {
/** /**
* @var Connection * @var Connection|\PHPUnit_Framework_MockObject_MockObject
*/ */
private $conn; private $conn;
...@@ -37,6 +37,11 @@ final class DB2SchemaManagerTest extends \PHPUnit_Framework_TestCase ...@@ -37,6 +37,11 @@ final class DB2SchemaManagerTest extends \PHPUnit_Framework_TestCase
$this->manager = new DB2SchemaManager($this->conn); $this->manager = new DB2SchemaManager($this->conn);
} }
/**
* @group DBAL-2701
* @see https://github.com/doctrine/dbal/issues/2701
* @return void
*/
public function testListTableNamesFiltersAssetNamesCorrectly() public function testListTableNamesFiltersAssetNamesCorrectly()
{ {
$this->conn->getConfiguration()->setFilterSchemaAssetsExpression('/^(?!T_)/'); $this->conn->getConfiguration()->setFilterSchemaAssetsExpression('/^(?!T_)/');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment